D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

loh tar noreply at phabricator.kde.org
Mon Feb 25 06:25:15 GMT 2019

loh.tar added a comment.

  Personally I would avoid doxygen style or multiline comments in code and prefer //


> katerenderer.cpp:988
>      // ensure minimal height of one pixel to not fall in the div by 0 trap somewhere
>      // use font line spacing, this includes the leading
> +    m_fontHeight = qMax(1, qCeil(config()->fontMetrics().ascent() + config()->fontMetrics().descent()));

a hint my good that lineSpacing() is not sufficient

> kateviewinternal.cpp:3024
>                  // first: paint our line
>                  // set clipping region if we paint the line above us, too

"second:" is gone

  R39 KTextEditor


To: cullmann, dhaumann
Cc: loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190225/579d22a3/attachment.html>

More information about the KWrite-Devel mailing list