<table><tr><td style="">loh.tar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19283">View Revision</a></tr></table><br /><div><div><p>Personally I would avoid doxygen style or multiline comments in code and prefer //</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19283#inline-107729">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:988</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// ensure minimal height of one pixel to not fall in the div by 0 trap somewhere</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// use font line spacing, this includes the leading</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_fontHeight</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">qCeil</span><span class="p">(</span><span class="n">config</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">lineSpacing</span></span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_fontHeight</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">qCeil</span><span class="p">(</span><span class="n">config</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">ascent</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">config</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">fontMetrics</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">descent</span></span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">a hint my good that lineSpacing() is not sufficient</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19283#inline-107728">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateviewinternal.cpp:3024</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #74777d">// first: paint our line</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #74777d">// set clipping region if we paint the line above us, too</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"second:" is gone</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19283">https://phabricator.kde.org/D19283</a></div></div><br /><div><strong>To: </strong>cullmann, dhaumann<br /><strong>Cc: </strong>loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>