D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

Dominik Haumann noreply at phabricator.kde.org
Tue Feb 19 20:39:41 GMT 2019

dhaumann added a comment.

  This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278.
  But yes, the Qt documentation says to use TextUnderlineStyle instead of FontUnderline. The implementation of fontUnderline() indeed also first tries to use TextUnderlineStyle, see: https://code.woboq.org/qt5/qtbase/src/gui/text/qtextformat.cpp.html#_ZNK15QTextCharFormat13fontUnderlineEv
  So from my side this change is OK, but probably before committing this should be tested again.

  R39 KTextEditor


To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190219/5070c6b6/attachment.html>

More information about the KWrite-Devel mailing list