D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QTextFormat::FontUnderline has been deprecated upstream for a long time.
  
  It seems that for some time setting the underline attribute for syntax
  highlighting has been broken, i.e. a user can't set it via the config
  widget and setKateExtendedAttributeList always sets it to false. The
  latter meant that when the user applied any changes that would write
  katesyntaxhighlightingrc, the underline attribute for syntax HL would
  unconditionally be set to false which leads to some weird situations,
  (e.g. bug 399278 where un/setting "highlight trailing spaces" causes
  katesyntaxhighlightingrc to get written to disk which leads to
  Markdown:linebreak losing its underline attribute for good).
  
  BUG: 399278
  FIXED-IN: 5.57

REPOSITORY
  R39 KTextEditor

BRANCH
  syntax-hl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19161

AFFECTED FILES
  src/schema/katestyletreewidget.cpp
  src/syntax/katehighlight.cpp
  src/syntax/katesyntaxmanager.cpp

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190219/20339df2/attachment.html>