D18864: FlatBuffers schema syntax highlighting

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.

INLINE COMMENTS

> flatbuffers.xml:4
> +
> +<language name="FlatBuffers" section="Sources"
> +    version="1" kateversion="5.0"

Could you add license="MIT"?

> flatbuffers.xml:58
> +                <DetectChar attribute="String" context="String" char="""/>
> +                <RegExpr attribute="Decimal" context="#stay" String="-?[0-9]+" />
> +                <Detect2Chars attribute="Comment" context="Comment1" char="/" char1="/"/>

Does the Int rule do the same?

https://docs.kde.org/stable5/en/applications/katepart/highlight.html

...or does it not include the minus sign?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190208/56cfc918/attachment-0001.html>