<table><tr><td style="">dhaumann accepted this revision.<br />dhaumann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18864">View Revision</a></tr></table><br /><div><div><p>Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not required to make sense, and best is also MIT licensed.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18864#inline-104808">View Inline</a><span style="color: #4b4d51; font-weight: bold;">flatbuffers.xml:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><language</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"FlatBuffers"</span> <span style="color: #354bb3">section=</span><span style="color: #766510">"Sources"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #354bb3">version=</span><span style="color: #766510">"1"</span> <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"5.0"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could you add license="MIT"?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18864#inline-104807">View Inline</a><span style="color: #4b4d51; font-weight: bold;">flatbuffers.xml:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><DetectChar</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"String"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"String"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"""</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Decimal"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"-?[0-9]+"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><Detect2Chars</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"Comment1"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"/"</span> <span style="color: #354bb3">char1=</span><span style="color: #766510">"/"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Does the Int rule do the same?</p>
<p style="padding: 0; margin: 8px;"><a href="https://docs.kde.org/stable5/en/applications/katepart/highlight.html" class="remarkup-link" target="_blank" rel="noreferrer">https://docs.kde.org/stable5/en/applications/katepart/highlight.html</a></p>
<p style="padding: 0; margin: 8px;">...or does it not include the minus sign?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>flatbuffers (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18864">https://phabricator.kde.org/D18864</a></div></div><br /><div><strong>To: </strong>harald, dhaumann<br /><strong>Cc: </strong>dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars<br /></div>