Remove session tests (which allows removing kdeinit_kate as well)?
christoph at cullmann.io
Thu Aug 15 14:11:38 BST 2019
On 2019-08-15 11:33, Daan De Meyer wrote:
> I've managed to remove all usages of the kdeinit_kate target in the
> addons directory. It turned out there were no tests actually relying
> on stuff from the kdeinit_kate target. Now the only targets remaining
> that rely on the kdeinit_kate target are Kate's session tests which
> are currently aborting with no one seemingly interested in fixing
> them. My proposal would be to remove the session tests and the
> kdeinit_kate target along with them (merging everything into the kate
> target) which allows simplifying the CMake setup a lot.
> One caveat is that removing the kdeinit_kate target would prevent
> testing any other core Kate classes (those not in addons) in the
> future but since most of Kate's testable features seem to be
> implemented in addons this might not be a big disadvantage.
> Any thoughts?
I don't think we want to remove the possibility to write unit tests
for Kate internals just to make that one CMakeLists.txt a bit smaller.
(given it works the way it is since years)
It would be nice if somebody could step up to fix the tests, thought.
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org
More information about the KWrite-Devel