D23010: Use range loop if possible

[Filip Gawin]

gawin added inline comments.

INLINE COMMENTS

> katefilebrowserconfig.cpp:162
>    QListWidget *lb;
> -  for ( QStringList::Iterator it = allActions.begin(); it != allActions.end(); ++it )
> +  for (const auto& action : allActions)
>    {

I'm not sure about name. Maybe `actionName` would be better?

> katemdi.cpp:983
>          // reshuffle toolviews only if needed
> -        for (int i = 0; i < m_toolviews.size(); ++i) {
> -            KMultiTabBar::KMultiTabBarPosition newPos = (KMultiTabBar::KMultiTabBarPosition) cg.readEntry(QStringLiteral("Kate-MDI-ToolView-%1-Position").arg(m_toolviews[i]->id), int(m_toolviews[i]->sidebar()->position()));
> +        for (const auto toolview : m_toolviews) {
> +            KMultiTabBar::KMultiTabBarPosition newPos = (KMultiTabBar::KMultiTabBarPosition) cg.readEntry(QStringLiteral("Kate-MDI-ToolView-%1-Position").arg(toolview->id), int(toolview->sidebar()->position()));

Also, camel case?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D23010

To: gawin, #kate
Cc: kwrite-devel, #kate, univerz, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190807/5b47f31c/attachment.html>