<table><tr><td style="">gawin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23010">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23010#inline-129728">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katefilebrowserconfig.cpp:162</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span class="n">QListWidget</span> <span style="color: #aa2211">*</span><span class="n">lb</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">QStringList</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Iterator</span></span><span class="bright"> </span><span class="n"><span class="bright">it</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">allA</span>ction<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">begin</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span><span class="bright"> </span><span class="n"><span class="bright">it</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!=</span></span> <span class="n">allActions<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">end</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">++</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"> </span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span style="color: #a0a000"><span class="bright">a</span>ction<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">allActions</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm not sure about name. Maybe <tt style="background: #ebebeb; font-size: 13px;">actionName</tt> would be better?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23010#inline-129729">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katemdi.cpp:983</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// reshuffle toolviews only if needed</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span> <span class="n">m_toolviews<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">++</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">KMultiTabBar</span><span style="color: #aa2211">::</span><span class="n">KMultiTabBarPosition</span> <span class="n">newPos</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">KMultiTabBar</span><span style="color: #aa2211">::</span><span class="n">KMultiTabBarPosition</span><span class="p">)</span> <span class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Kate-MDI-ToolView-%1-Position"</span><span class="p">).</span><span class="n">arg</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>toolview<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span style="color: #aa2211">-></span><span class="n">id</span><span class="p">),</span> <span style="color: #aa4000">int</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>toolview<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span style="color: #aa2211">-></span><span class="n">sidebar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">position</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span style="color: #a0a000"><span class="bright">toolview</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">m_toolviews</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">KMultiTabBar</span><span style="color: #aa2211">::</span><span class="n">KMultiTabBarPosition</span> <span class="n">newPos</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">KMultiTabBar</span><span style="color: #aa2211">::</span><span class="n">KMultiTabBarPosition</span><span class="p">)</span> <span class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Kate-MDI-ToolView-%1-Position"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">toolview</span><span style="color: #aa2211">-></span><span class="n">id</span><span class="p">),</span> <span style="color: #aa4000">int</span><span class="p">(</span><span class="n">toolview</span><span style="color: #aa2211">-></span><span class="n">sidebar</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">position</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Also, camel case?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23010">https://phabricator.kde.org/D23010</a></div></div><br /><div><strong>To: </strong>gawin, Kate<br /><strong>Cc: </strong>kwrite-devel, Kate, univerz, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann<br /></div>