D15804: Fix Duplicates on Quick Open File
noreply at phabricator.kde.org
Fri Sep 28 08:40:45 BST 2018
tcanabrava added a comment.
In D15804#333078 <https://phabricator.kde.org/D15804#333078>, @cullmann wrote:
> In principle the code looks even cleaner this way, thought the speed should be profiled.
> I assume it is a bit ugly to write a unit test for this.
> Given I didn't touch this code since long, a second opinion here would be good.
> Sven did some changes here in the past, perhaps he can take a look.
> About the QFileInfo: I am not sure, how expensive the pure construction and that one function is.
> Should be profiled.
To: tcanabrava, cullmann, brauch, neundorf
Cc: kwrite-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel