D15804: Fix Duplicates on Quick Open File

Christoph Cullmann noreply at phabricator.kde.org
Fri Sep 28 08:37:58 BST 2018

cullmann added a comment.

  In principle the code looks even cleaner this way, thought the speed should be profiled.
  I assume it is a bit ugly to write a unit test for this.
  Given I didn't touch this code since long, a second opinion here would be good.
  Sven did some changes here in the past, perhaps he can take a look.
  About the QFileInfo: I am not sure, how expensive the pure construction and that one function is.
  Should be profiled.

  R40 Kate


To: tcanabrava, cullmann, brauch, neundorf
Cc: kwrite-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180928/6efaf4eb/attachment.html>

More information about the KWrite-Devel mailing list