D15207: precompute attribute format for context & rules

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  avoid costly lookup, e.g. 3% of runtime of highlighting
  
  simplifies the highlightLine stuff, as we only need to keep track of format changes,
  not lookup contexts in addition
  
  fixes that we don't see that formats change if name is equal in different
  definitions
  
  accessors are inline, the classes are internal anyways

TEST PLAN
  make && make test
  
  updated references, now we properly applyFormat if we walk from one into a other
  definition with same name formats

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15207

AFFECTED FILES
  autotests/html/csharp.cs.html
  autotests/html/highlight.cmake.html
  autotests/html/highlight.cpp.html
  autotests/html/highlight.css.html
  autotests/html/highlight.dox.html
  autotests/html/highlight.hs.html
  autotests/html/highlight.js.html
  autotests/html/highlight.lhs.html
  autotests/html/highlight.lua.html
  autotests/html/highlight.qml.html
  autotests/html/highlight.tex.html
  autotests/html/highlight.y.html
  autotests/html/modelines.py.html
  autotests/html/test.Rd.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.py.html
  autotests/html/test.qml.html
  autotests/html/test.te.html
  autotests/reference/csharp.cs.ref
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.cpp.ref
  autotests/reference/highlight.css.ref
  autotests/reference/highlight.dox.ref
  autotests/reference/highlight.gdb.ref
  autotests/reference/highlight.hs.ref
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.lhs.ref
  autotests/reference/highlight.lua.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/highlight.tex.ref
  autotests/reference/highlight.y.ref
  autotests/reference/modelines.py.ref
  autotests/reference/review128925-1.css.ref
  autotests/reference/review128925-2.css.ref
  autotests/reference/test.Rd.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.py.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.te.ref
  src/lib/abstracthighlighter.cpp
  src/lib/context.cpp
  src/lib/context_p.h
  src/lib/definition.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180901/23642bee/attachment.html>