<table><tr><td style="">cullmann created this revision.<br />cullmann added reviewers: vkrause, dhaumann.<br />Herald added projects: Kate, Frameworks.<br />Herald added subscribers: kde-frameworks-devel, kwrite-devel.<br />cullmann requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15207">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>avoid costly lookup, e.g. 3% of runtime of highlighting</p>

<p>simplifies the highlightLine stuff, as we only need to keep track of format changes,<br />
not lookup contexts in addition</p>

<p>fixes that we don't see that formats change if name is equal in different<br />
definitions</p>

<p>accessors are inline, the classes are internal anyways</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>make && make test</p>

<p>updated references, now we properly applyFormat if we walk from one into a other<br />
definition with same name formats</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15207">https://phabricator.kde.org/D15207</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/html/csharp.cs.html<br />
autotests/html/highlight.cmake.html<br />
autotests/html/highlight.cpp.html<br />
autotests/html/highlight.css.html<br />
autotests/html/highlight.dox.html<br />
autotests/html/highlight.hs.html<br />
autotests/html/highlight.js.html<br />
autotests/html/highlight.lhs.html<br />
autotests/html/highlight.lua.html<br />
autotests/html/highlight.qml.html<br />
autotests/html/highlight.tex.html<br />
autotests/html/highlight.y.html<br />
autotests/html/modelines.py.html<br />
autotests/html/test.Rd.html<br />
autotests/html/test.coffee.html<br />
autotests/html/test.htm.html<br />
autotests/html/test.js.html<br />
autotests/html/test.py.html<br />
autotests/html/test.qml.html<br />
autotests/html/test.te.html<br />
autotests/reference/csharp.cs.ref<br />
autotests/reference/highlight.cmake.ref<br />
autotests/reference/highlight.cpp.ref<br />
autotests/reference/highlight.css.ref<br />
autotests/reference/highlight.dox.ref<br />
autotests/reference/highlight.gdb.ref<br />
autotests/reference/highlight.hs.ref<br />
autotests/reference/highlight.js.ref<br />
autotests/reference/highlight.lhs.ref<br />
autotests/reference/highlight.lua.ref<br />
autotests/reference/highlight.qml.ref<br />
autotests/reference/highlight.tex.ref<br />
autotests/reference/highlight.y.ref<br />
autotests/reference/modelines.py.ref<br />
autotests/reference/review128925-1.css.ref<br />
autotests/reference/review128925-2.css.ref<br />
autotests/reference/test.Rd.ref<br />
autotests/reference/test.coffee.ref<br />
autotests/reference/test.htm.ref<br />
autotests/reference/test.js.ref<br />
autotests/reference/test.jsx.ref<br />
autotests/reference/test.py.ref<br />
autotests/reference/test.qml.ref<br />
autotests/reference/test.te.ref<br />
src/lib/abstracthighlighter.cpp<br />
src/lib/context.cpp<br />
src/lib/context_p.h<br />
src/lib/definition.cpp<br />
src/lib/rule.cpp<br />
src/lib/rule_p.h</div></div></div><br /><div><strong>To: </strong>cullmann, vkrause, dhaumann<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>