D15804: Fix Duplicates on Quick Open File

gregormi noreply at phabricator.kde.org
Mon Oct 15 20:44:59 BST 2018


gregormi added inline comments.

INLINE COMMENTS

> dhaumann wrote in katequickopenmodel.h:14
> Could be done with enum class. Then you'd have to write Column::FileName etc (along with static_cast<int>(...)).

Hmm, that would be 11 instances of std::get<...> which then will look not so nice. The current version seems like a good compromise.

REPOSITORY
  R40 Kate

BRANCH
  fixDuplicatesQuickOpen2

REVISION DETAIL
  https://phabricator.kde.org/D15804

To: tcanabrava, cullmann, brauch, neundorf
Cc: gregormi, dhaumann, kwrite-devel, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181015/a711523c/attachment.html>


More information about the KWrite-Devel mailing list