D15804: Fix Duplicates on Quick Open File

Dominik Haumann noreply at phabricator.kde.org
Mon Oct 15 20:34:42 BST 2018


dhaumann added inline comments.

INLINE COMMENTS

> gregormi wrote in katequickopenmodel.h:14
> I wonder if there is a good way to make it more clear that these enum symbols are used as implicitly casted column index numbers later.

Could be done with enum class. Then you'd have to write Column::FileName etc (along with static_cast<int>(...)).

REPOSITORY
  R40 Kate

BRANCH
  fixDuplicatesQuickOpen2

REVISION DETAIL
  https://phabricator.kde.org/D15804

To: tcanabrava, cullmann, brauch, neundorf
Cc: gregormi, dhaumann, kwrite-devel, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181015/de45b3f3/attachment.html>


More information about the KWrite-Devel mailing list