D16018: Fix align of doxygen comments

Bernd Buschinski noreply at phabricator.kde.org
Sun Oct 7 16:47:46 BST 2018


buschinski created this revision.
buschinski added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
buschinski requested review of this revision.

REVISION SUMMARY
  After 
  https://bugs.kde.org/show_bug.cgi?id=360456
  https://cgit.kde.org/ktexteditor.git/commit/?id=58baf7c318d4641a243ea18f04ef15ee017509e3
  
  the align of doxygen comments in templates stopped working.
  
  Without the patch:
  
    /**
    * foo
    */
    void foo();
  
  with the patch:
  
    /**
     * foo
     */
    void foo();
  
  TODO: the added testcase does work with and without the patch. I can not create a reproducible test and need some help.
  
  currently only reproducible with kdevelop

TEST PLAN
  - start kdevelop
  - open any c/cpp file with functions
  - select the function / click in the name
  - Code -> Document Declaration
  
  -> not properly align
  
  - LD_PRELOAD=libKF5TextEditor.so kdevelop (with the patch)
  - repeat the rest of the steps
  
  -> correctly aligned

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16018

AFFECTED FILES
  autotests/input/indent/cstyle/doxygen11/expected
  autotests/input/indent/cstyle/doxygen11/input.js
  autotests/input/indent/cstyle/doxygen11/origin
  src/script/data/indentation/cstyle.js

To: buschinski, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181007/a5c1423a/attachment.html>


More information about the KWrite-Devel mailing list