D17193: KateViewInternal: Remove unneeded functions

loh tar noreply at phabricator.kde.org
Thu Nov 29 14:37:06 GMT 2018


loh.tar updated this revision to Diff 46473.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Prefer function calls for member excess
  - Merge KateViewInternal::updateView with KateViewInternal::doUpdateView
  - Add documentation to related functions and some near by cosmetic. Well, "Better no docu than bad docu", so if that is to difficult to check now, I can remove it and ship as own diff
  - Complete commit message
  - Remove Testplan, I'm always surpsised to see that later in the commit message

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17193?vs=46411&id=46473

REVISION DETAIL
  https://phabricator.kde.org/D17193

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181129/56c85f6d/attachment.html>


More information about the KWrite-Devel mailing list