D16926: Review user interaction in session management

[loh tar]

loh.tar updated this revision to Diff 46175.
loh.tar added a comment.


  Glad to read that :-)
  
  - I have grouped the buttons by functionality, and always dislike designs where dangerous functionality is near placed by often used one. So my biggest objection here are the similar looking Delete and Close buttons. That's why are separated by a spacer. But I understand that there are also "Design-Rules" exist to place always the same function in the same order at the same place. Now with the ui-file design can that relatively easy changed. Perhaps after a first "field test"?
  
  - Your screenshot looks indeed not so nice with the big Document column and the small Session one. Updated as suggested and renamed to a shorter text. How about to remove (hide) the Document/Files column? They show by the way not the correct count when you open/closed some in the meantime. I have an additionally patch here which try to solve this but looks to me a little overkill, but perhaps you like it.
  
  F6440381: 1543127536.png <https://phabricator.kde.org/F6440381>

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16926?vs=45709&id=46175

REVISION DETAIL
  https://phabricator.kde.org/D16926

AFFECTED FILES
  kate/CMakeLists.txt
  kate/data/kateui.rc
  kate/katemainwindow.cpp
  kate/session/katesessionchooser.cpp
  kate/session/katesessionchooser.h
  kate/session/katesessionmanagedialog.cpp
  kate/session/katesessionmanagedialog.h
  kate/session/katesessionmanagedialog.ui
  kate/session/katesessionmanager.cpp
  kate/session/katesessionmanager.h
  kate/session/katesessionopendialog.cpp
  kate/session/katesessionopendialog.h

To: loh.tar, #kate
Cc: anthonyfieroni, cullmann, kwrite-devel, #kate, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181125/43528fd3/attachment-0001.html>