D17145: Don't reverse order of files opened from the command line

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kateapp.cpp:180
> +    QString positionalArgument;
> +    for (int i = m_args.positionalArguments().count()-1; i >= 0; i--) {
> +        positionalArgument = m_args.positionalArguments().at(i);

Missing spaces around `-`. Also, we traditionally use `--i` instead of `i--`.

> main.cpp:421
> +            for (int i = urls.size()-1; i >= 0; i--) {
> +                const QString & url = urls[i];
>                  QDBusMessage m = QDBusMessage::createMethodCall(serviceName,

No space after `&`, because it is the unary reference operator, not the binary "and" operator.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17145

To: gmolteni, cfeck, zetazeta, ngraham, #kate
Cc: kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181125/2631aff7/attachment.html>