<table><tr><td style="">cfeck requested changes to this revision.<br />cfeck added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17145">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17145#inline-93415">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateapp.cpp:180</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">positionalArgument</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">m_args</span><span class="p">.</span><span class="n">positionalArguments</span><span class="p">().</span><span class="n">count</span><span class="p">()</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211">--</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">positionalArgument</span> <span style="color: #aa2211">=</span> <span class="n">m_args</span><span class="p">.</span><span class="n">positionalArguments</span><span class="p">().</span><span class="n">at</span><span class="p">(</span><span class="n">i</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing spaces around <tt style="background: #ebebeb; font-size: 13px;">-</tt>. Also, we traditionally use <tt style="background: #ebebeb; font-size: 13px;">--i</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">i--</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17145#inline-93416">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:421</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">urls</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211">--</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span> <span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">urls</span><span class="p">[</span><span class="n">i</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">QDBusMessage</span> <span class="n">m</span> <span style="color: #aa2211">=</span> <span class="n">QDBusMessage</span><span style="color: #aa2211">::</span><span class="n">createMethodCall</span><span class="p">(</span><span class="n">serviceName</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No space after <tt style="background: #ebebeb; font-size: 13px;">&</tt>, because it is the unary reference operator, not the binary "and" operator.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17145">https://phabricator.kde.org/D17145</a></div></div><br /><div><strong>To: </strong>gmolteni, cfeck, zetazeta, ngraham, Kate<br /><strong>Cc: </strong>kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann<br /></div>