D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

Nathaniel Graham noreply at phabricator.kde.org
Mon Nov 19 21:50:50 GMT 2018


ngraham accepted this revision.
ngraham added reviewers: Kate, KTextEditor.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good from my perspective! Let's see what the #kate <https://phabricator.kde.org/tag/kate/> folks think.

INLINE COMMENTS

> slenz wrote in kateview.cpp:543
> I think they both make sense, but "Toggle Comment" seems to be the established standard. Three out of my four installed editors used that wording (the last one only used "Comment").

OK, let's let the Kate folks have final say then.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D17008_1

REVISION DETAIL
  https://phabricator.kde.org/D17008

To: slenz, #vdg, ngraham, #kate, #ktexteditor
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181119/3aad8c75/attachment-0001.html>


More information about the KWrite-Devel mailing list