D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

Silas Lenz noreply at phabricator.kde.org
Mon Nov 19 21:46:05 GMT 2018

slenz marked an inline comment as done.
slenz added inline comments.


> ngraham wrote in katepart5ui.rc:2
> You need to bump the version to 79 or else the changes won't take effect.

That might explain why the changes only sometimes appeared. Fixed :)

> ngraham wrote in kateview.cpp:543
> Could we also change this string to say "Comment/Uncomment" Rather than "Toggle comment"? I know that's //technically// correct because this is a toggle action, but generally one doesn't associate "toggling" things with text editing.

I think they both make sense, but "Toggle Comment" seems to be the established standard. Three out of my four installed editors used that wording (the last one only used "Comment").

  R39 KTextEditor


To: slenz, #vdg, ngraham
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181119/a1149319/attachment.html>

More information about the KWrite-Devel mailing list