D16926: Review user interaction in session management

Christoph Cullmann noreply at phabricator.kde.org
Sat Nov 17 15:14:48 GMT 2018


cullmann added a comment.


  Hi,
  
  I will give that patch some try locally ;=)
  
  For the question:
  
  // Q:Is that the right way to protect for not available dbus? See main.cpp
  520		‚Äč#ifndef USE_QT_SINGLE_APP
  
  I think it is enough to check if
  
  QDBusConnectionInterface *i = QDBusConnection::sessionBus().interface();
  
  is null, like done, not sure if the define check is needed at all. (as we still link against qdbus, just not want to rely on it working)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16926

To: loh.tar, #kate
Cc: cullmann, kwrite-devel, #kate, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181117/e3e04a74/attachment.html>


More information about the KWrite-Devel mailing list