D16926: Review user interaction in session management

loh tar noreply at phabricator.kde.org
Fri Nov 16 16:20:27 GMT 2018


loh.tar created this revision.
loh.tar added a reviewer: Kate.
loh.tar added a project: Kate.
Herald added a subscriber: kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - SessionManageDialog
    - Build user interface by ui file
    - Avoid obsolete Qt members
    - Choose more meaningful member names
    - Add filter field and sort button
    - Open session by double click
    - Add buttons for "Copy" and "Open as Template"
    - Reorder a couple of code to be a little bit more logic ordered
    - Delete a session with delay which offer a restore and avoid annoying confirmation dialog
    - Rename a session inside of the list view to avoid extra popup window to enter the new name.
  
  - Remove SessionOpenDialog, use SessionManageDialog instead
  - Remove SessionChooser, use SessionManageDialog instead
  
  - SessionManager
    - Add signal sessionListChanged() To avoid unneded signals is updateSessionList() slightly modified with a clearer look and an added check for changes in an easy way.
    - Add copySession()
    - Let rename/copySession() ask for a new name when needed
    - Move session creation parts from newSessionName() to sessionSaveAs()
    - Rename newSessionName() to askForNewSessionName()
    - Add suggestNewSessionName()
    - Don't create anonymous session in ctor
    - Don't save anonymous session as last session
  
  - MainWindow
    - Remove from sessions menu "Open Session" because it's now the same as "Manage Sessions"

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16926

AFFECTED FILES
  kate/CMakeLists.txt
  kate/data/kateui.rc
  kate/katemainwindow.cpp
  kate/session/katesessionchooser.cpp
  kate/session/katesessionchooser.h
  kate/session/katesessionmanagedialog.cpp
  kate/session/katesessionmanagedialog.h
  kate/session/katesessionmanagedialog.ui
  kate/session/katesessionmanager.cpp
  kate/session/katesessionmanager.h
  kate/session/katesessionopendialog.cpp
  kate/session/katesessionopendialog.h

To: loh.tar, #kate
Cc: kwrite-devel, #kate, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181116/95f5595b/attachment.html>


More information about the KWrite-Devel mailing list