[PATCH 0/8] SymbolView: Be a little smarter and avoid cpu last

Dominik Haumann dhaumann at kde.org
Sun Jul 22 23:52:37 BST 2018


Hi,

as Christoph said, these patches are very much appreciated. Please don't
hesitate to make larger changes that improve the Plugin. Indeed, the code
is old and should be improved.

Best regards
Dominik

Dr.-Ing. Christoph Cullmann <cullmann at absint.com> schrieb am So., 22. Juli
2018, 16:10:

> Hi,
>
> I appreciate the work on the plugin.
>
> It would make sense if you submit your patches in phabricator.
>
> https://phabricator.kde.org/
>
> That way, one can review them in a more nice way and we don't spam other
> list members ;=)
>
> Greetings
> Christoph
>
> ----- Am 22. Jul 2018 um 15:01 schrieb loh.tar loh.tar at googlemail.com:
>
> > Hello!
> >
> > These small series is a byproduct while I have written a new parser type
> which
> > you will find in some other thread.
> >
> > Most of these patches do not fix a really big bug but do things a little
> bit
> > better. So, at the end of the day there are a lot CPU cycles saved and
> maybe
> > some nerves of the user spared.
> >
> > BTW: The related code looks a little abandoned but I resist e.g the
> temptation
> > to run these 'astyle' command, noted somewhere in your coding
> guidelines, or to
> > make bigger alterations. There are many possibilities for improvements.
> >
> > Because this is my very first post to some mailing list like yours,
> please
> > forgive if I have done something not as I should.
> >
> > Thanks, Lothar
> >
> > loh.tar (8):
> >  SymbolView: Fix broken toggle actions
> >  SymbolView: Reduce redundant code
> >  SymbolView: Qt docu recommends to populate view with disabled sorting
> >  SymbolView: Avoid unneeded update of current item
> >  SymbolView: Update current item and sorting after parsing
> >  SymbolView: Avoid unneeded update of current item II
> >  SymbolView: Reduce flicker of view in tree mode when edit text
> >  SymbolView: Fix: Find new current item when symbol is in first line
> >
> > .../symbolviewer/plugin_katesymbolviewer.cpp  | 101 ++++++++++--------
> > addons/symbolviewer/plugin_katesymbolviewer.h |   3 +
> > 2 files changed, 61 insertions(+), 43 deletions(-)
> >
> > --
> > 2.18.0
>
> --
> ----------------------------- Dr.-Ing. Christoph Cullmann ---------
> AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
> Science Park 1                         Tel:   +49-681-38360-22
> 66123 Saarbrücken                      Fax:   +49-681-38360-20
> GERMANY                                WWW:   http://www.AbsInt.com
> --------------------------------------------------------------------
> Geschäftsführung: Dr.-Ing. Christian Ferdinand
> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180723/712434ae/attachment.html>


More information about the KWrite-Devel mailing list