D17730: Review KateStatusBar

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, this seems to break the unit tests :/
  
  see https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/167/testReport/junit/projectroot.autotests.src/vimode/vimode_view/
  
  >>> running command  "llllljgjr."  on text  "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
  
  QDEBUG : ViewTest::visualLineUpDownTests() org.kde.ktexteditor: Invalid position: ( 0 , -1 )
  FAIL!  : ViewTest::visualLineUpDownTests() Compared values are not the same
  
    Actual   (kate_document->text()): "stickyhelper\n     .XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
    Expected (expected_text)        : "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .INE3"
    Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.9/autotests/src/vimode/view.cpp(222)]
  
  QDEBUG : ViewTest::visualLineUpDownTests()
  
  >>> running command  "llllljgjgkr."  on text  "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
  
  QDEBUG : ViewTest::visualLineUpDownTests() org.kde.ktexteditor: Invalid position: ( 0 , -1 )
  FAIL!  : ViewTest::visualLineUpDownTests() Compared values are not the same
  
    Actual   (kate_document->text()): "stick.helper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
    Expected (expected_text)        : "stickyhelper\n     .XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
    Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.9/autotests/src/vimode/view.cpp(227)]
  
  QDEBUG : ViewTest::visualLineUpDownTests()

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor, cullmann
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181230/1b149428/attachment-0001.html>