<table><tr><td style="">cullmann reopened this revision.<br />cullmann added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17730">View Revision</a></tr></table><br /><div><div><p>Hmm, this seems to break the unit tests :/</p>

<p>see <a href="https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/167/testReport/junit/projectroot.autotests.src/vimode/vimode_view/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/167/testReport/junit/projectroot.autotests.src/vimode/vimode_view/</a></p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>running command  "llllljgjr."  on text  "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"</p></blockquote></blockquote></blockquote>

<p>QDEBUG : ViewTest::visualLineUpDownTests() org.kde.ktexteditor: Invalid position: ( 0 , -1 )<br />
FAIL!  : ViewTest::visualLineUpDownTests() Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (kate_document->text()): "stickyhelper\n     .XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
Expected (expected_text)        : "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .INE3"
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.9/autotests/src/vimode/view.cpp(222)]</pre></div>

<p>QDEBUG : ViewTest::visualLineUpDownTests()</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>running command  "llllljgjgkr."  on text  "stickyhelper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"</p></blockquote></blockquote></blockquote>

<p>QDEBUG : ViewTest::visualLineUpDownTests() org.kde.ktexteditor: Invalid position: ( 0 , -1 )<br />
FAIL!  : ViewTest::visualLineUpDownTests() Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (kate_document->text()): "stick.helper\n     XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
Expected (expected_text)        : "stickyhelper\n     .XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX LINE3"
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.9/autotests/src/vimode/view.cpp(227)]</pre></div>

<p>QDEBUG : ViewTest::visualLineUpDownTests()</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17730">https://phabricator.kde.org/D17730</a></div></div><br /><div><strong>To: </strong>loh.tar, KTextEditor, cullmann<br /><strong>Cc: </strong>zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, KTextEditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann<br /></div>