D16336: BuildView: Avoid to show ToolView when build is invoked

loh tar noreply at phabricator.kde.org
Mon Dec 17 14:56:38 GMT 2018


loh.tar updated this revision to Diff 47717.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Fix switch/case coding style
  - QRegExp -> QRegularExpression
  - Remove 'Build still in progress' hint because now is always such hint active and besides, it would be immediately replaced again
  - Only auto-hide on default target. I think this could be acceptable now
  - Add progressinfo as KTextEditor::Message
  
  Hint
  
  - buildCurrentTarget() returns bool but is never used
  
  Possible change: Only show progress hint when view is not visible

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16336?vs=47571&id=47717

REVISION DETAIL
  https://phabricator.kde.org/D16336

AFFECTED FILES
  addons/katebuild-plugin/plugin_katebuild.cpp
  addons/katebuild-plugin/plugin_katebuild.h

To: loh.tar, #kate, sars
Cc: yurchor, cullmann, sars, kwrite-devel, #kate, hase, michaelh, ngraham, demsking, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181217/caa0fc54/attachment.html>


More information about the KWrite-Devel mailing list