D16336: BuildView: Avoid to show ToolView when build is invoked

Kåre Särs noreply at phabricator.kde.org
Sat Dec 15 19:06:35 GMT 2018

sars added a comment.

  I think one magic build name is not the best way to enable auto-hiding.
  If you absolutely need auto-hiding it has to be an option somewhere... Maybe a checkbox on the output tab on the right of the slider.


> plugin_katebuild.cpp:589
> +        if (!m_infoMessage) {
> +            postMessage(i18n("Building target is still in progress..."), KTextEditor::Message::Information);
> +        }

Why the type change?

> plugin_katebuild.cpp:712
>      else if (exitCode != 0) {
> -        displayBuildResult(i18n("Build failed."), KTextEditor::Message::Warning);
> +        postMessage(i18n("Build failed."), KTextEditor::Message::Error);
>      }

Why the type change? You get a exitCode != 0 also if you only have a warning.


To: loh.tar, #kate, sars
Cc: yurchor, cullmann, sars, kwrite-devel, #kate, hase, michaelh, ngraham, demsking, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181215/bd3a0aaa/attachment-0001.html>

More information about the KWrite-Devel mailing list