D17459: SearchBar: Add Cancel button to stop long running tasks
noreply at phabricator.kde.org
Tue Dec 11 21:43:39 GMT 2018
cullmann added a comment.
For: Um, have updated before read this. have droped your std::unique_ptr because im not familar with, no idea if my solution has ugly drawbacks. Is there a need to delete the hold object now?
> Yes, as keeping a MovingRange alive has a cost (it will need to be updated on each editing action), therefore one should create it before the find/replaceAll and delete it afterwards. A unique_ptr doesn't do much more than ensuring it is deleted at end of life-time of the object, too.
To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel