D16336: BuildView: Avoid to show ToolView when build is invoked

Kåre Särs noreply at phabricator.kde.org
Mon Dec 10 07:00:48 GMT 2018

sars added a comment.

  Sorry, I was a bit busy when this review came and then I forgot about it :(
  Show ToolView when build is invoked but is already in progress
  Rename displayBuildResult->postMessage to fit new use cases
  Use postMessage indstead of KMessageBox on some infos because it is less annoying
  I'm not sure about the auto-hiding. Quite often I want to see the result after the build.
  Thanks for pushing improvements! :)


> plugin_katebuild.cpp:740
> +        QRegExp rx = QRegExp(QStringLiteral("^\\[([\\s\\d\\%]+)\\]"));
> +        if (line.contains(rx)) {
> +            // QString name = fetchPluginName();

The idea is good, but until it works it is best to not output debug messages.

If it would be possible to use the same plasma integrated progress indication as dolphin it would be nice, but if it would be only in the toolview you kinda already have it there.

  R40 Kate


To: loh.tar, #kate, sars
Cc: cullmann, sars, kwrite-devel, #kate, hase, michaelh, ngraham, demsking, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181210/09bed282/attachment.html>

More information about the KWrite-Devel mailing list