D17459: SearchBar: Add Cancel button to stop long running tasks
noreply at phabricator.kde.org
Sun Dec 9 19:50:16 GMT 2018
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
The idea is good, I only am not sure that we want it with process events.
That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that.
It would be better to refactor the replaceAll method in a way that it does
2. trigger the search part wise via e.g. single shot timer
3. some finalize phase at the end
To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel