D17441: tune editing actions for large number of small edits

Dominik Haumann noreply at phabricator.kde.org
Sun Dec 9 08:09:41 GMT 2018

dhaumann added inline comments.


> katetextrange.h:364
> +     */
> +    bool m_isCheckValidityRequired = false;
>  };

I would prefer an additional

  inline void setValidityCheckRequired();
  inline bool validityCheckRequired() const;

We don't need a bool in the setter, since we always only mark dirty. And with these accessors, you could add a unit test (in dact, I would like to see one for this).

And instead of 'double' I suggest to use the term 'multiple' in the comment.

> anthonyfieroni wrote in katesearchbar.cpp:815
> You can preserve say 1024 i think.

If it's not an issue at all, I prefer to have limits that are realistic. If it scales well for, say 4096, then 4096 is the better choice.

  R39 KTextEditor


To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181209/6a288c05/attachment.html>

More information about the KWrite-Devel mailing list