D15134: decrease StateData space by more than 50% and half the number of needed mallocs
noreply at phabricator.kde.org
Wed Aug 29 08:44:38 BST 2018
cullmann added a comment.
For: I can't answer the m_defData question without digging deeper into this unfortunately. The rest looks good to me though.
Ok. I think in 99% of the cases it is save enough, thought some 100% save thing would be nicer. Actually one could just add a shared::ptr to keep the definition alive to the state.
For the indentationBasedFoldingEnabled() detach: Actually, do we want to have the implicit stuff at all there?
I would tend to just use a std::vector as stack as we do the sharing ourself (and ensure we return pointer equal states in highlightLine)
R216 Syntax Highlighting
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel