D15134: decrease StateData space by more than 50% and half the number of needed mallocs
noreply at phabricator.kde.org
Wed Aug 29 08:41:10 BST 2018
vkrause added a comment.
I can't answer the m_defData question without digging deeper into this unfortunately. The rest looks good to me though.
> return false;
> - return d->m_contextStack.top()->indentationBasedFoldingEnabled();
> + return d->m_contextStack.last().first->indentationBasedFoldingEnabled();
last() has a non-const (detaching) overload, is there a risk we are hitting this here due to the d-> indirection? All other occurrences seem to be clearly on const members.
R216 Syntax Highlighting
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel