D14890: Remove QSaveFile in favor of plain old file saving

Christoph Cullmann noreply at phabricator.kde.org
Sat Aug 18 11:01:41 BST 2018


cullmann added a comment.


  For the QFile case, I added now this check:
  
    // did save work?
      // FIXME for KCompressionDevice
      if (qobject_cast<QFileDevice *>(saveFile.data()) && qobject_cast<QFileDevice *>(saveFile.data())->error() != QFileDevice::NoError) {
          BUFFER_DEBUG << "Saving file " << filename << "failed with error" << saveFile->errorString();
          return false;
      }
  
  that seems to handle the QFile case well.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14890

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180818/72237b22/attachment.html>


More information about the KWrite-Devel mailing list