D14826: inline note interface wip #2

Michal Srb noreply at phabricator.kde.org
Tue Aug 14 14:53:59 BST 2018

michalsrb added a comment.

  Thank you for working on this. This interface would work for the kdev-sourceinfo use case just as well as the old one.
  I think the problem with the old interface that you described is valid. This version gives more flexibility to the `InlineNotesProvider` with regards to how it stores the notes internally.
  Do you have plan how to track the movement of the notes during edits? Maybe the InlineNote could also hold revision number for which it was created?


> inlinenoteinterface.h:145
> +     */
> +    virtual QVector<int> inlineNotes(int line) const = 0;
> +

Perhaps this could be `QVarLengthArray` of some size too?

  R39 KTextEditor


To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180814/a557b3ec/attachment-0001.html>

More information about the KWrite-Devel mailing list