D14826: inline note interface wip #2

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katerenderer.cpp:765
> +        // Draw inline notes
> +        auto inlineNotes = m_view->inlineNotes(range->line());
> +        foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {

const

> katerenderer.cpp:766
> +        auto inlineNotes = m_view->inlineNotes(range->line());
> +        foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {
> +            int column = inlineNote.column();

for (const auto& inlineNote : inlineNotes) {

> katerenderer.cpp:1048-1049
> +
> +    auto inlineNotes = m_view->inlineNotes(lineLayout->line());
> +    foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) {
> +        int column = inlineNote.column();

same as above

> kateview.cpp:3653-3654
> +
> +        connect(provider, SIGNAL(reset()), this, SLOT(inlineNotesReset()));
> +        connect(provider, SIGNAL(lineChanged(int)), this, SLOT(inlineNotesLineChanged(int)));
> +

Use new syntax connect

> kateview.cpp:3666
> +
> +        disconnect(provider, nullptr, this, nullptr);
> +

provider->disconnect(this);

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14826

To: brauch, michalsrb, dhaumann, cullmann
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180814/dca38070/attachment-0001.html>