<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14826">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14826#inline-78537">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:765</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #74777d">// Draw inline notes</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">auto</span> <span class="n">inlineNotes</span> <span style="color: #aa2211">=</span> <span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">inlineNotes</span><span class="p">(</span><span class="n">range</span><span style="color: #aa2211">-></span><span class="n">line</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">InlineNote</span><span style="color: #aa2211">&</span> <span class="n">inlineNote</span><span class="p">,</span> <span class="n">inlineNotes</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14826#inline-78538">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:766</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">auto</span> <span class="n">inlineNotes</span> <span style="color: #aa2211">=</span> <span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">inlineNotes</span><span class="p">(</span><span class="n">range</span><span style="color: #aa2211">-></span><span class="n">line</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">InlineNote</span><span style="color: #aa2211">&</span> <span class="n">inlineNote</span><span class="p">,</span> <span class="n">inlineNotes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">int</span> <span class="n">column</span> <span style="color: #aa2211">=</span> <span class="n">inlineNote</span><span class="p">.</span><span class="n">column</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for (const auto& inlineNote : inlineNotes) {</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14826#inline-78539">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katerenderer.cpp:1048-1049</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span class="n">inlineNotes</span> <span style="color: #aa2211">=</span> <span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">inlineNotes</span><span class="p">(</span><span class="n">lineLayout</span><span style="color: #aa2211">-></span><span class="n">line</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">InlineNote</span><span style="color: #aa2211">&</span> <span class="n">inlineNote</span><span class="p">,</span> <span class="n">inlineNotes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span class="n">column</span> <span style="color: #aa2211">=</span> <span class="n">inlineNote</span><span class="p">.</span><span class="n">column</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same as above</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14826#inline-78540">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateview.cpp:3653-3654</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">provider</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">reset</span><span class="p">()),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">inlineNotesReset</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">provider</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">lineChanged</span><span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">inlineNotesLineChanged</span><span class="p">(</span><span style="color: #aa4000">int</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use new syntax connect</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14826#inline-78541">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateview.cpp:3666</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">disconnect</span><span class="p">(</span><span class="n">provider</span><span class="p">,</span> <span style="color: #aa4000">nullptr</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">provider->disconnect(this);</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14826">https://phabricator.kde.org/D14826</a></div></div><br /><div><strong>To: </strong>brauch, michalsrb, dhaumann, cullmann<br /><strong>Cc: </strong>anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>