D14620: SymbolView: Add expand and parameter options to popup menu

Kåre Särs noreply at phabricator.kde.org
Mon Aug 6 11:29:38 BST 2018

sars added a comment.

  Except for the actionTriggered() function I'm ready to accept this patch.
  Examples of options that are not saved when changed from menus: View -> font size changes, View -> Word wrap -> *, View -> Border -> *, Tools -> Spelling -> *,....
  It is a design decision to have permanent changes in the settings pages and temporary document specific changes in the menus.


> plugin_katesymbolviewer.cpp:269
> +{
> +  m_expandOn->setEnabled(m_treeOn->isChecked());
> +  parseSymbols();

What I meant was that you could move this line to parseSymbols() and not add a new "wrapper" function with only one extra line of code...

If you absolutely want to save the one setEnabled() for the timer-based document update, please use a more descriptive name like displayOptionChanged() or something similar.


To: loh.tar, #kate, sars
Cc: sars, kwrite-devel, #kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180806/b6c01c1b/attachment.html>

More information about the KWrite-Devel mailing list