D14620: SymbolView: Add expand and parameter options to popup menu

[Kåre Särs]

sars added a comment.


  I think it is ok to add these to the popup.
  
  1. The changes in the settings page is permanent, while the changes in the popup-menu is temporary -> I don't want to get rid of the settings page.
  
  2. actionTriggered() is now almost like the removed slotRefreshSymbols() and besides all parsers are already checking the expand on status... do we need actionTriggered()?
  
  3. I would like to have expandOn to behave like a default value and if I manually toggle the tree it should stay that way also if the document is changed. At the moment it expands/collapses all the tree-nodes.
  
  This would be a change from the current behavior. Changing the expandOn should of course apply the change immediately.
  
  (4) I did not want the name-change ;)
  
  Thanks,
  
    Kåre

REVISION DETAIL
  https://phabricator.kde.org/D14620

To: loh.tar, #kate, sars
Cc: sars, kwrite-devel, #kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180805/492e14a1/attachment.html>