D7851: Update Signals&Slots of Addons

Lays Rodrigues noreply at phabricator.kde.org
Thu Sep 21 12:56:51 UTC 2017


laysrodrigues added a comment.


  In https://phabricator.kde.org/D7851#147107, @dhaumann wrote:
  
  > Are we sure this doesn't add regressions? Somethings connections are also disconnected, and as far as I know, mixing a new-style connect with an old-style disconnect does not work. If we are sure this works, then I'm all for it.
  >
  > PS: I did not go over the patch.
  
  
  If I wasn't able to change the 'connect' to the new pattern, the disconnect was also not changed. Now about the regression, I can't say much. I know that this is a big patch and is hard to review all the changes.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7851

To: laysrodrigues, cullmann, kwrite-devel
Cc: dhaumann, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20170921/3bd52662/attachment.html>


More information about the KWrite-Devel mailing list