Unit Test broken
safa1996alfulaij at gmail.com
Tue Dec 26 04:49:52 UTC 2017
Alright, that fixed the unit test!
No need to revert anything, from my side :)
2017-12-25 17:58 GMT+03:00 Safa Alfulaij <safa1996alfulaij at gmail.com>:
> Maybe the problem is the sequence of setting beginCursor.
> Maybe moving https://cgit.kde.org/ktexteditor.git/tree/src/
> document/katedocument.cpp#n3203 to be before the if (!isValidTextPosition(
> beginCursor)) statment will solve the problem, but not really sure and
> can't test.
> I don't see any other difference than this.
> 2017-12-25 17:44 GMT+03:00 Safa Alfulaij <safa1996alfulaij at gmail.com>:
>> Please revert the patch as I don't have more time to investigate this,
>> My system isn't ready for such testing and I need time to fix it (most
>> probably in the mid of January)
>> Sorry for all the mess.
>> 2017-12-25 12:59 GMT+03:00 Dominik Haumann <dhaumann at kde.org>:
>>> Hi Safa,
>>> Looking at https://build.kde.org, ktexteditor is yellow since your
>>> change. Could you have a look at the unit test again?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel