Unit Test broken

Safa Alfulaij safa1996alfulaij at gmail.com
Mon Dec 25 14:58:41 UTC 2017

Maybe the problem is the sequence of setting beginCursor.
Maybe moving
to be before the if (!isValidTextPosition(beginCursor)) statment will solve
the problem, but not really sure and can't test.
I don't see any other difference than this.

2017-12-25 17:44 GMT+03:00 Safa Alfulaij <safa1996alfulaij at gmail.com>:

> Hi
> Please revert the patch as I don't have more time to investigate this,
> sorry.
> My system isn't ready for such testing and I need time to fix it (most
> probably in the mid of January)
> Sorry for all the mess.
> Regards
> 2017-12-25 12:59 GMT+03:00 Dominik Haumann <dhaumann at kde.org>:
>> Hi Safa,
>> Looking at https://build.kde.org, ktexteditor is yellow since your
>> change. Could you have a look at the unit test again?
>> Greetings
>> Dominik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20171225/79dc2a3e/attachment.html>

More information about the KWrite-Devel mailing list