[Kwintv] ALSA mixer patch
Dirk Ziegelmeier
dirk at ziegelmeier.net
Tue Jul 29 23:42:30 CEST 2003
Hi,
I've made a few fixes to the ALSA plugin because it has IMHO a rather strange
behaviour:
- It ignores setVolume calls if the mixer is muted <-> OSS unmutes and applies
volume
- It doesn't actually set volume on a setVolume() call, it just stores it in
class attributes <-> OSS immediately applies
- Volume is set on a volumeLeft() or volumeRight() call. This was unnoticed
since qtvision almost always reads back volume immediately after setting.
I added a note to qvmixerplugin.h to make the API more clear in these cases.
The applied patches don't fix any bug for me, but I think they may prevent
further bugs.
ChangeLog: ALSA mixer cleanup, qvmixerplugin documentation update
Neil Macvicar (ALSA plugin author), can you please comment my changes? Do you
think they are OK?
Ciao,
Dirk
--
Dirk Ziegelmeier * dirk at ziegelmeier.net * http://www.ziegelmeier.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qvmixerplugin.h.patch
Type: text/x-diff
Size: 914 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kwintv/attachments/20030729/2c26fe9a/qvmixerplugin.h.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qtvision_alsa.cpp.patch
Type: text/x-diff
Size: 3042 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kwintv/attachments/20030729/2c26fe9a/qtvision_alsa.cpp.bin
More information about the kwintv
mailing list