D29772: Don't compare string with empty string

Kai Uwe Broulik noreply at phabricator.kde.org
Fri May 15 10:38:27 BST 2020


broulik added inline comments.

INLINE COMMENTS

> ognarb wrote in FileDialogLoader.qml:39
> I didn't know that an empty string in js was returning false.

It's not, but the operators in JS work a little differently. They don't cast to bool.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29772

To: ognarb, #plasma, iasensio
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/aee4da74/attachment.htm>


More information about the kwin mailing list