D29772: Don't compare string with empty string

Carl Schwan noreply at phabricator.kde.org
Fri May 15 10:37:55 BST 2020


ognarb planned changes to this revision.
ognarb added inline comments.

INLINE COMMENTS

> broulik wrote in FileDialogLoader.qml:39
> Why not just `!root.lastFolder`? or even
> 
>   root.lastFolder || shortcuts.home

I didn't know that an empty string in js was returning false.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29772

To: ognarb, #plasma, iasensio
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/b2dc51de/attachment-0001.htm>


More information about the kwin mailing list