D29684: Improve opengl debug messages

Vlad Zahorodnii noreply at phabricator.kde.org
Thu May 14 17:46:53 BST 2020


zzag added inline comments.

INLINE COMMENTS

> zzag wrote in scene_opengl.cpp:414
>   while (message[length] == '\0')
>       length--;
> 
> will cutoff the last character, e.g. if we have "abcd\0" then only "abc" will be printed. More conservative trimming algorithm will look something like this
> 
>   while (message[length - 1] == '\n' || message[length - 1] == '\r')
>       --length;

while (length && isspace(message[length - 1])
      --length;

this one is a bit more safer

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29684

To: apol, #kwin
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200514/9c674071/attachment-0001.htm>


More information about the kwin mailing list