D29684: Improve opengl debug messages

Vlad Zahorodnii noreply at phabricator.kde.org
Thu May 14 17:36:52 BST 2020


zzag added inline comments.

INLINE COMMENTS

> scene_opengl.cpp:414
>          Q_UNUSED(userParam)
> -        while (message[length] == '\n' || message[length] == '\r')
> +        while (message[length] == '\n' || message[length] == '\r' || message[length] == 0)
>              --length;

while (message[length] == '\0')
      length--;

will cutoff the last character, e.g. if we have "abcd\0" then only "abc" will be printed. More conservative trimming algorithm will look something like this

  while (message[length - 1] == '\n' || message[length - 1] == '\r')
      --length;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29684

To: apol, #kwin
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200514/722836c2/attachment.htm>


More information about the kwin mailing list