D29729: Improve partial maximization strings

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> options.cpp:761
>      setOperationMaxButtonLeftClick(windowOperation(config.readEntry("MaximizeButtonLeftClickCommand", "Maximize"), true));
> -    setOperationMaxButtonMiddleClick(windowOperation(config.readEntry("MaximizeButtonMiddleClickCommand", "Maximize (vertical only)"), true));
> +    setOperationMaxButtonMiddleClick(windowOperation(config.readEntry("MaximizeButtonMiddleClickCommand", "Vertically Maximize"), true));
>      setOperationMaxButtonRightClick(windowOperation(config.readEntry("MaximizeButtonRightClickCommand", "Maximize (horizontal only)"), true));

"Maximize" must be in lowecase.

> options.cpp:762
> +    setOperationMaxButtonMiddleClick(windowOperation(config.readEntry("MaximizeButtonMiddleClickCommand", "Vertically Maximize"), true));
>      setOperationMaxButtonRightClick(windowOperation(config.readEntry("MaximizeButtonRightClickCommand", "Maximize (horizontal only)"), true));
>  

The default value for right click hasn't been adjusted.

> options.cpp:985-987
> +    else if (name == QStringLiteral("Vertically maximize"))
>          return VMaximizeOp;
> +    else if (name == QStringLiteral("Horizontally maximize"))

This will break existing user installations.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29729

To: ngraham, zzag, #vdg, #kwin, davidedmundson
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200514/08ec5669/attachment.htm>